Preserve connecting status while a turn starts by D3OXY · Pull Request #4101 · pingdotgg/t3code

D3OXY · 2026-07-17T19:52:16Z

What Changed

Preserve the connecting thread status while provider readiness arrives with a turn start still pending. The thread transitions directly to working once the turn starts instead of briefly appearing inactive.

Why

Status-grouped thread lists currently jump between sections during provider startup because readiness temporarily exposes an idle state.

Fixes #4099

Verification

vp check
vp run typecheck
vp test: lifecycle coverage passed; the unrelated ACP timeout passed 14/14 on targeted retry.

Checklist

This PR is small and focused
I explained what changed and why
UI screenshots included
Video included

Note

Preserve 'starting' session status while a turn start is pending

When thread.turn.start is handled, the session is immediately projected as starting before the provider session is fully ready, and remains starting even if the provider reports ready until a turn actually begins.
ProviderRuntimeIngestion maps session.state.changed 'ready' and session.started events to starting (rather than ready) when a pending turn-start exists for the thread.
On thread.session-set with terminal statuses (error, stopped, interrupted), any pending turn-start records for the thread are deleted via projectionTurnRepository.deletePendingTurnStartByThreadId.
setThreadSessionErrorOnTurnStartFailure now constructs a minimal session from the thread when none exists, setting status to error (or keeping stopped) so turn failures are always surfaced.
Behavioral Change: sessions that previously became ready between turn-start and the first turn event will now show starting instead.

^{Macroscope summarized 919bd72.}

coderabbitai · 2026-07-17T19:52:36Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 603c59f7-ec6f-4949-8c59-a0e97b3b2a07

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-07-17T20:03:08Z

Approvability

Verdict: Needs human review

This PR modifies session state machine behavior in the orchestration layer, changing how status transitions during turn startup. The changes affect core runtime state management across multiple files, warranting human review despite good test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

Co-authored-by: codex <codex@users.noreply.github.com>

Dismissing prior approval to re-evaluate 1c1aa71

Co-authored-by: codex <codex@users.noreply.github.com>

Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a)

…dotgg#2284) (#184) * Sidebar v2 beta: flat thread list with a server-backed settled lifecycle (pingdotgg#4026) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net> (cherry picked from commit 32c6012) * fix(settings): validate the add-provider wizard step before advancing (pingdotgg#2813) (pingdotgg#3100) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 282ecb3) * fix(claude): isolate capability probe from user MCP servers (pingdotgg#4015) Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit aa5ec80) * Preserve connecting status while a turn starts (pingdotgg#4101) Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a) * fix(server): stop restoring stale OpenCode models (pingdotgg#4095) Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 4e09cdd) * [codex] keep scoped package references as text (pingdotgg#4167) Co-authored-by: codex <codex@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> (cherry picked from commit c7b21ff) * fix(web): default provider selection for users without Codex (pingdotgg#4117) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit b6e1b39) * Unify temporary worktree branch naming (pingdotgg#4278) (cherry picked from commit 571a8b4) * fix(web): use message-square icon for settled icon-less project threads in sidebar v2 (pingdotgg#4279) (cherry picked from commit 020179c) * Stabilize sidebar settling animations (pingdotgg#4280) (cherry picked from commit 18b4688) * Restore Copy Link in chat link context menu (pingdotgg#4161) Co-authored-by: Julius Marminge <julius0216@outlook.com> (cherry picked from commit e5fba26) * fix(desktop): handle EPIPE errors on stdout/stderr to prevent crash dialog (pingdotgg#4213) (cherry picked from commit f74eb62) * Preserve draft thread highlighting during promotion (pingdotgg#4283) Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 18fa89c) * Move mobile working timer into the thread timeline (pingdotgg#4285) (cherry picked from commit 7e2bb47) * Stabilize PR status lookups and provider session lifecycle (pingdotgg#4281) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 376c149) * fix: open command palette instead of custom dialog for new thread picker in SidebarV2 (pingdotgg#4269) (cherry picked from commit 9fe4832) * fix(server): don't drop sticky PR fallback when remote URL can't be resolved (pingdotgg#4289) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 9a0a071) * feat(web): copy branch name via right-click in the branch selector (pingdotgg#4275) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 78a0ea5) * Add remote server updates and standalone service management (pingdotgg#4286) Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit ab4a883) * Refine light-mode sidebar surfaces (pingdotgg#4268) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 593289c) * fix(mobile): don't mark Android VPN/Tailscale as offline when connected (pingdotgg#3949) (cherry picked from commit bc9428a) * improve and prevent silent thread branch drift and PR fetching (pingdotgg#2284) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 2d31cb0) * fix(sync): restore fork migration IDs under Sidebar v2 settled Upstream pingdotgg#4026 replaced Migrations.ts with linear upstream numbering and dropped fork-only migrations (NormalizeLegacyProviderKinds, RepairProposedPlanColumns, BackfillForkProviderInstanceIds). Restore the fork registry and append ProjectionThreadsSettled as ID 36. Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com> --------- Co-authored-by: Theo Browne <me@t3.gg> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Leonel Rivas <encriptandost@gmail.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com> Co-authored-by: Jaret Bottoms <jaretbottoms@gmail.com> Co-authored-by: Ishan <ishansachu1@gmail.com> Co-authored-by: Yukun Shan <92423096+nateEc@users.noreply.github.com> Co-authored-by: Maxwell Young <maxtheyoung@gmail.com> Co-authored-by: Miklós Fazekas <mfazekas@szemafor.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com> Co-authored-by: Henry Zhang <113233555+caezium@users.noreply.github.com> Co-authored-by: Rushikesh Gaikwad <81632222+Wraient@users.noreply.github.com> Co-authored-by: legs <145564979+justsomelegs@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>

github-actions Bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Jul 17, 2026

github-actions Bot added the size:M 30-99 changed lines (additions + deletions). label Jul 17, 2026

macroscopeapp Bot previously approved these changes Jul 17, 2026

View reviewed changes

juliusmarminge force-pushed the d3oxy/fix-pending-turn-startup branch from fb8870e to 1c1aa71 Compare July 22, 2026 13:07

juliusmarminge pushed a commit to D3OXY/t3code that referenced this pull request Jul 22, 2026

Preserve pending startup lifecycle for PR pingdotgg#4101

1c1aa71

Co-authored-by: codex <codex@users.noreply.github.com>

Preserve pending startup lifecycle for PR pingdotgg#4101

919bd72

Co-authored-by: codex <codex@users.noreply.github.com>

juliusmarminge force-pushed the d3oxy/fix-pending-turn-startup branch from 1c1aa71 to 919bd72 Compare July 22, 2026 13:15

juliusmarminge merged commit 783692a into pingdotgg:main Jul 22, 2026
14 checks passed

UNN-Devotek pushed a commit to unn-corp/t3code that referenced this pull request Jul 23, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

bb35740

Co-authored-by: codex <codex@users.noreply.github.com>

AnanduB13 pushed a commit to AnanduB13/t3code that referenced this pull request Jul 23, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

6d011cf

Co-authored-by: codex <codex@users.noreply.github.com>

cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

31de7ab

Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a)

cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

d6d68f1

Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a)

cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

650acfd

Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a)

cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

2558e17

Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a)

cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

046a4e1

Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a)

cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

52a4842

Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a)

cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

d21c599

Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a)

cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

9e973e9

Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a)

cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

d081ebb

Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a)

cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

92a5920

Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a)

cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

c222980

Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a)

cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026

Preserve connecting status while a turn starts (pingdotgg#4101)

4fb1044

Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Preserve connecting status while a turn starts#4101

Preserve connecting status while a turn starts#4101
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
D3OXY:d3oxy/fix-pending-turn-startup

D3OXY commented Jul 17, 2026 •

edited by macroscopeapp Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

Review skipped

Uh oh!

macroscopeapp Bot commented Jul 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

D3OXY commented Jul 17, 2026 • edited by macroscopeapp Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Why

Verification

Checklist

Preserve 'starting' session status while a turn start is pending

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

macroscopeapp Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

D3OXY commented Jul 17, 2026 •

edited by macroscopeapp Bot

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

macroscopeapp Bot commented Jul 17, 2026 •

edited

Loading